Re: [Xen-devel] [PATCH] oprofile: Add X7542 and E7-8837 to the list of supported cpus

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.11.12 at 15:21, Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx> wrote:
> Am Dienstag 27 November 2012, 13:19:34 schrieb Jan Beulich:
>> >>> On 27.11.12 at 14:04, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> >>>> On 26.11.12 at 13:52, Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx> wrote:
>> >> Add intel cpus X7542 and E7-8837 to the list of supported cpus.
>> >> 
>> >> Thanks.
>> >> Dietmar.
>> >> 
>> >> Signed-off-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
>> >> 
>> >> diff -r 0049de3827bc -r 6fb0129600cd xen/arch/x86/oprofile/nmi_int.c
>> >> --- a/xen/arch/x86/oprofile/nmi_int.c   Fri Nov 23 11:06:15 2012 +0000
>> >> +++ b/xen/arch/x86/oprofile/nmi_int.c   Mon Nov 26 13:36:00 2012 +0100
>> >> @@ -366,6 +366,8 @@ static int __init ppro_init(char ** cpu_
>> >>                 ppro_has_global_ctrl = 1;
>> >>                 break;
>> >>         case 26:
>> >> +       case 46:
>> >> +       case 47:
>> >>                 arch_perfmon_setup_counters();
>> >>                 *cpu_type = "i386/core_i7";
>> >>                 ppro_has_global_ctrl = 1;
>> > 
>> > Actually, and apart from the patch being white space damaged,
>> > after a closer look I think this is wrong - these newer CPUs
>> > shouldn't get be handled here, but instead should be covered by
>> > arch_perfmon_init(). Are you observing X86_FEATURE_ARCH_PERFMON
>> > not getting set on these CPUs by init_intel()?
>> 
>> I.e. the below would be the patch I'd expect when merely
>> taking the SDM as reference (with the "todo remove?" ones
>> also fully removed of course).
> 
> Yes, looks much cleaner.

Question is - does it work for you? And if it does, why would it not
have worked without any change? After all, the patch in this form,
apart from the setting of ppro_has_global_ctrl in
arch_perfmon_init(), only removes code.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel