Re: [Xen-devel] [PATCH] oprofile: Add X7542 and E7-8837 to the list of supported cpus

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.11.12 at 13:52, Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx> wrote:
> Add intel cpus X7542 and E7-8837 to the list of supported cpus.
> 
> Thanks.
> Dietmar.
> 
> Signed-off-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> 
> diff -r 0049de3827bc -r 6fb0129600cd xen/arch/x86/oprofile/nmi_int.c
> --- a/xen/arch/x86/oprofile/nmi_int.c   Fri Nov 23 11:06:15 2012 +0000
> +++ b/xen/arch/x86/oprofile/nmi_int.c   Mon Nov 26 13:36:00 2012 +0100
> @@ -366,6 +366,8 @@ static int __init ppro_init(char ** cpu_
>                 ppro_has_global_ctrl = 1;
>                 break;
>         case 26:
> +       case 46:
> +       case 47:
>                 arch_perfmon_setup_counters();
>                 *cpu_type = "i386/core_i7";
>                 ppro_has_global_ctrl = 1;

Actually, and apart from the patch being white space damaged,
after a closer look I think this is wrong - these newer CPUs
shouldn't get be handled here, but instead should be covered by
arch_perfmon_init(). Are you observing X86_FEATURE_ARCH_PERFMON
not getting set on these CPUs by init_intel()?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel