[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] oprofile: Add X7542 and E7-8837 to the list of supported cpus


  • To: xen-devel@xxxxxxxxxxxxx
  • From: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
  • Date: Tue, 27 Nov 2012 15:13:17 +0100
  • Cc: Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Tue, 27 Nov 2012 14:13:43 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:From:To:Cc:Subject:Date:Message-ID: User-Agent:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:Content-Type; b=Q8cwmFf391Vgp9OLLokH8h8G+SVdNQms773q2y/RA2sBq+xzgfhjyjil qx4KYwEfUhBHo6jn60nsnwxFy240m+KdOi8UIofpcxm5w1s2+vBzvFeyZ saXO5kigiGon08KlyOMPDy5Iz3ydY232/uIxl4KJf6cck3inhWeZAJbIy bf9gxxt0LwwoB2GVayteGih9Fe0uimeQBglNI8SjLSKgdK2ObST/HqbfQ nc5unA81F9u+mUUOEwacJ3g5f40lT;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

Am Dienstag 27 November 2012, 13:04:36 schrieb Jan Beulich:
> >>> On 26.11.12 at 13:52, Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx> wrote:
> > Add intel cpus X7542 and E7-8837 to the list of supported cpus.
> > 
> > Thanks.
> > Dietmar.
> > 
> > Signed-off-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> > 
> > diff -r 0049de3827bc -r 6fb0129600cd xen/arch/x86/oprofile/nmi_int.c
> > --- a/xen/arch/x86/oprofile/nmi_int.c   Fri Nov 23 11:06:15 2012 +0000
> > +++ b/xen/arch/x86/oprofile/nmi_int.c   Mon Nov 26 13:36:00 2012 +0100
> > @@ -366,6 +366,8 @@ static int __init ppro_init(char ** cpu_
> >                 ppro_has_global_ctrl = 1;
> >                 break;
> >         case 26:
> > +       case 46:
> > +       case 47:
> >                 arch_perfmon_setup_counters();
> >                 *cpu_type = "i386/core_i7";
> >                 ppro_has_global_ctrl = 1;
> 
> Actually, and apart from the patch being white space damaged,
> after a closer look I think this is wrong - these newer CPUs
> shouldn't get be handled here, but instead should be covered by
> arch_perfmon_init(). Are you observing X86_FEATURE_ARCH_PERFMON
> not getting set on these CPUs by init_intel()?

Yes you are right. I wasn't aware of this!
Dietmar.

> 
> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 
-- 
Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.