Re: [Xen-devel] [PATCH 2 of 4] minios/console: console_input() weak reference

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-11-27 at 11:52 +0000, Samuel Thibault wrote:
> Ian Campbell, le Tue 27 Nov 2012 11:46:41 +0000, a Ãcrit :
> > > > And by extension I suppose xencons_tx too, for parity if nothing else.
> > > 
> > > I actually wonder what the purpose of xencons_tx is.
> > 
> > I suppose if you had a shared ring serial console you could accept
> > input?
> 
> I'm afraid I still don't understand :)

Oops, I confused my tx and my rx here ;-)

> 
> > > > The existing console_input function (previously xencons_rx) is pretty
> > > > odd, it relies on something reusing a tx buffer for rx?
> > > 
> > > ? I don't see what you are referring to.
> > 
> > xencons_rx says /* Just repeat what's written */ and prints the contents
> > of the buffer
> 
> Yes, it echoes what was typed on the console by the user.
> 
> > (this is rx remember, so buffer ought to be an output buffer, not
> > input)
> 
> Really?  It's not what I understand from console_handle_input, which
> just consumes data from the ring and gives it to xencons_rx, without
> emiting any.

Oh, xencons_rx is the function called when data is received on the
console, as opposed to a function which is expected to receive data from
the console itself (which is the other possible reading of the name).
Sorry, my confusion, plus being too lazy to run cscope in order to find
the caller.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel