[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2 of 4] minios/console: console_input() weak reference
Ian Campbell, le Tue 27 Nov 2012 11:34:39 +0000, a écrit : > On Mon, 2012-11-26 at 21:42 +0000, Samuel Thibault wrote: > > Andrew Cooper, le Mon 26 Nov 2012 16:24:10 +0000, a écrit : > > > In exactly the same style as app_main() in kernel.c, create a weak > > > reference console_input() function for applications to override to > > > quickly gain access to the console. > > > > > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > > > > Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> > > Any reason not to make xencons_rx itself the weak function? I'd avoid exposing the pt_regs structure. Maybe we could drop the parameter from the xencons_rx function itself indeed, it has no use. > And by extension I suppose xencons_tx too, for parity if nothing else. I actually wonder what the purpose of xencons_tx is. > The existing console_input function (previously xencons_rx) is pretty > odd, it relies on something reusing a tx buffer for rx? ? I don't see what you are referring to. Samuel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |