Re: [Xen-devel] [PATCH] libxl: Make an internal function explicitly check existence of expected paths

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-11-23 at 15:56 +0000, George Dunlap wrote:
> +        LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
> +                   "Internal error: Missing xenstore node %s/removable", 
> be_path);

One or two of these new log lines are > 80 columns. You might find that
using the shorthand LOG*() macros helps with this.

Personally I don't think the "Internal error" tag is necessary either,
but maybe a new return code ERROR_INTERNAL might make sense? or even an
assert() if this is really a "libxl failed to maintain internal
consistency" ?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel