Re: [Xen-devel] [PATCH 2 of 4] minios/console: console_input() weak reference

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-11-26 at 21:42 +0000, Samuel Thibault wrote:
> Andrew Cooper, le Mon 26 Nov 2012 16:24:10 +0000, a Ãcrit :
> > In exactly the same style as app_main() in kernel.c, create a weak
> > reference console_input() function for applications to override to
> > quickly gain access to the console.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Any reason not to make xencons_rx itself the weak function? And by
extension I suppose xencons_tx too, for parity if nothing else.

The existing console_input function (previously xencons_rx) is pretty
odd, it relies on something reusing a tx buffer for rx?

Ian.

> 
> > diff -r 505992114832 -r 29138c27eb72 extras/mini-os/console/console.c
> > --- a/extras/mini-os/console/console.c
> > +++ b/extras/mini-os/console/console.c
> > @@ -54,9 +54,7 @@
> >     NOTE: you need to enable verbose in xen/Rules.mk for it to work. */
> >  static int console_initialised = 0;
> >  
> > -
> > -#ifndef HAVE_LIBC
> > -void xencons_rx(char *buf, unsigned len, struct pt_regs *regs)
> > +__attribute__((weak)) void console_input(char * buf, unsigned len)
> >  {
> >      if(len > 0)
> >      {
> > @@ -69,6 +67,12 @@ void xencons_rx(char *buf, unsigned len,
> >      }
> >  }
> >  
> > +#ifndef HAVE_LIBC
> > +void xencons_rx(char *buf, unsigned len, struct pt_regs *regs)
> > +{
> > +    console_input(buf, len);
> > +}
> > +
> >  void xencons_tx(void)
> >  {
> >      /* Do nothing, handled by _rx */
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel
> > 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel