Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Stefano Stabellini wrote:
> On Tue, 6 Nov 2012, Liu, Jinsong wrote:
>> Liu, Jinsong wrote:
>>> Stefano Stabellini wrote:
>>>>>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>>>>>> index 0e86370..a2af622 100644
>>>>>> --- a/drivers/xen/Makefile
>>>>>> +++ b/drivers/xen/Makefile
>>>>>> @@ -29,6 +29,7 @@ obj-$(CONFIG_XEN_MCE_LOG)           += mcelog.o
>>>>>>  obj-$(CONFIG_XEN_PCIDEV_BACKEND)     += xen-pciback/
>>>>>>  obj-$(CONFIG_XEN_PRIVCMD)            += xen-privcmd.o
>>>>>>  obj-$(CONFIG_XEN_ACPI_PROCESSOR)     += xen-acpi-processor.o
>>>>>> +obj-$(CONFIG_XEN_DOM0)                       += xen_acpi_pad.o
>>>>>>  xen-evtchn-y                         := evtchn.o
>>>>>>  xen-gntdev-y                         := gntdev.o
>>>>>>  xen-gntalloc-y                               := gntalloc.o
>>>> 
>>>> it should really depend on ACPI and maybe also X86, otherwise it
>>>> is going to break the ARM build 
>>>> 
>>>> 
>>> 
>>> Hmm, XEN_DOM0 has already depended on ACPI and X86_LOCAL_APIC
>>> (which depends on X86_64). 
>>> 
>> 
>> Ah, you and Konrad are right. I ignore XEN_DOM0 varies under
>> different arch. (But seems it not depends on X86 since it's
>> logically an acpi stuff?). 
> 
> If it is generic ACPI code, than it can depend only on ACPI.
> If it is ACPI code that contains X86 specific info, than it needs to
> depend on X86 too.

No x86 specific so let's depend on ACPI.

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel