Re: [Xen-devel] [PATCH, v2] fix build with XEN and EARLY_PRINTK_DBGP enabled but USB_SUPPORT disabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.10.12 at 17:50, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Oct 29, 2012 at 04:45:54PM +0000, Jan Beulich wrote:
>> Since there's no possible caller of dbgp_external_startup() and
>> dbgp_reset_prep() when !USB_EHCI_HCD, there's no point in building and
>> exporting these functions in that case. This eliminates a build error
>> under the conditions listed in the subject, introduced with the merge
>> f1c6872e4980bc4078cfaead05f892b3d78dea64.
> 
> That's a merge commit, is that where the problem happened because Linus
> did the merge resolution incorrectly, or is it really due to some other
> patch that added this feature incorrectly?

It was indeed the merge that broke things (Linus just followed
the recommendation from Stefano, which weren't consistent
with the rest of the code).

Jan

> If the latter, please provide that git commit id.
> 
> thanks,
> 
> greg k-h




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel