Re: [Xen-devel] [PATCH, v2] fix build with XEN and EARLY_PRINTK_DBGP enabled but USB_SUPPORT disabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.10.12 at 23:17, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 29 Oct 2012, Jan Beulich wrote:
> 
>> Since there's no possible caller of dbgp_external_startup() and
>> dbgp_reset_prep() when !USB_EHCI_HCD, there's no point in building and
>> exporting these functions in that case. This eliminates a build error
>> under the conditions listed in the subject, introduced with the merge
>> f1c6872e4980bc4078cfaead05f892b3d78dea64.
>> 
>> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
>> ---
>> v2: Switch the dependency from USB_SUPPORT to USB_EHCI_HCD as requested
>>     by Alan (albeit I don't really agree to that change).
> 
> Considering that the rest of ehci-dbgp.c is specific to EHCI hardware,
> using USB_EHCI_HCD seems to me like a reasonable thing to do.
> 
>> ---
>>  arch/x86/kernel/cpu/perf_event_p6.c |    2 +-
> 
> What's up with this?

I had to fix an unrelated build issue, and while I removed the
resulting change from the patch, I forgot to update the diffstat
(I had lumped that change into the same patch). So please
ignore this wrong piece of information.

Jan

>>  drivers/usb/early/ehci-dbgp.c       |   15 +++++++++------
>>  2 files changed, 10 insertions(+), 7 deletions(-)
> 
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel