[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH, v2] fix build with XEN and EARLY_PRINTK_DBGP enabled but USB_SUPPORT disabled



On Mon, Oct 29, 2012 at 09:50:47AM -0700, Greg KH wrote:
> On Mon, Oct 29, 2012 at 04:45:54PM +0000, Jan Beulich wrote:
> > Since there's no possible caller of dbgp_external_startup() and
> > dbgp_reset_prep() when !USB_EHCI_HCD, there's no point in building and
> > exporting these functions in that case. This eliminates a build error
> > under the conditions listed in the subject, introduced with the merge
> > f1c6872e4980bc4078cfaead05f892b3d78dea64.
> 
> That's a merge commit, is that where the problem happened because Linus
> did the merge resolution incorrectly, or is it really due to some other

No. He did it based on what we (Stefano and me) thought was the correct
way that address the ARM and generic patches merge.

While it did work - Randy found via his random config generator
cronjob that it did not address all of the EHCI/EARLY/USB/PCI
combinations.

> patch that added this feature incorrectly?
> 
> If the latter, please provide that git commit id.
> 
> thanks,
> 
> greg k-h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.