Re: [Xen-devel] [PATCH 17/21] xen: xen_ulong_t substitution

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 5 Oct 2012, Jan Beulich wrote:
> >>> On 05.10.12 at 12:38, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> > --- a/tools/python/xen/lowlevel/xc/xc.c
> > +++ b/tools/python/xen/lowlevel/xc/xc.c
> > @@ -1439,7 +1439,7 @@ static PyObject *pyxc_xeninfo(XcObject *self)
> >      if ( xc_version(self->xc_handle, XENVER_commandline, &xen_commandline) 
> > != 0 )
> >          return pyxc_error_to_exception(self->xc_handle);
> >  
> > -    snprintf(str, sizeof(str), "virt_start=0x%lx", p_parms.virt_start);
> > +    snprintf(str, sizeof(str), "virt_start=0x%"PRI_xen_ulong, 
> > p_parms.virt_start);
> 
> Does that build on x86? I ask because ...
> 
> >  
> >      xen_pagesize = xc_version(self->xc_handle, XENVER_pagesize, NULL);
> >      if (xen_pagesize < 0 )
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > index e3d4ad9..2ae6548 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -122,7 +122,8 @@ typedef uint64_t xen_pfn_t;
> >  /* Only one. All other VCPUS must use VCPUOP_register_vcpu_info */
> >  #define XEN_LEGACY_MAX_VCPUS 1
> >  
> > -typedef uint32_t xen_ulong_t;
> > +typedef uint64_t xen_ulong_t;
> > +#define PRI_xen_ulong PRIx64
> 
> ... this doesn't seem to have an x86 counterpart.
> 

xen/include/public/arch-x86/xen.h defines xen_ulong_t but it looks like
that  it is missing PRI_xen_ulong

> 
> >  
> >  struct vcpu_guest_context {
> >  #define _VGCF_online                   0
> > diff --git a/xen/include/public/version.h b/xen/include/public/version.h
> > index 8742c2b..c7e6f8c 100644
> > --- a/xen/include/public/version.h
> > +++ b/xen/include/public/version.h
> > @@ -28,6 +28,8 @@
> >  #ifndef __XEN_PUBLIC_VERSION_H__
> >  #define __XEN_PUBLIC_VERSION_H__
> >  
> > +#include "xen.h"
> > +
> >  /* NB. All ops return zero on success, except XENVER_{version,pagesize} */
> >  
> >  /* arg == NULL; returns major:minor (16:16). */
> > @@ -58,7 +60,7 @@ typedef char xen_changeset_info_t[64];
> >  
> >  #define XENVER_platform_parameters 5
> >  struct xen_platform_parameters {
> > -    unsigned long virt_start;
> > +    xen_ulong_t virt_start;
> >  };
> >  typedef struct xen_platform_parameters xen_platform_parameters_t;
> >  
> > -- 
> > 1.7.9.1
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel