Re: [Xen-devel] [PATCH 17/21] xen: xen_ulong_t substitution

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-10-05 at 12:00 +0100, Jan Beulich wrote:
> >>> On 05.10.12 at 12:38, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> > --- a/tools/python/xen/lowlevel/xc/xc.c
> > +++ b/tools/python/xen/lowlevel/xc/xc.c
> > @@ -1439,7 +1439,7 @@ static PyObject *pyxc_xeninfo(XcObject *self)
> >      if ( xc_version(self->xc_handle, XENVER_commandline, &xen_commandline) 
> > != 0 )
> >          return pyxc_error_to_exception(self->xc_handle);
> >  
> > -    snprintf(str, sizeof(str), "virt_start=0x%lx", p_parms.virt_start);
> > +    snprintf(str, sizeof(str), "virt_start=0x%"PRI_xen_ulong, 
> > p_parms.virt_start);
> 
> Does that build on x86? I ask because ...

I appear to have forgotten to build test the tools side on x86, which
was remiss of me.

> >  
> >      xen_pagesize = xc_version(self->xc_handle, XENVER_pagesize, NULL);
> >      if (xen_pagesize < 0 )
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > index e3d4ad9..2ae6548 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -122,7 +122,8 @@ typedef uint64_t xen_pfn_t;
> >  /* Only one. All other VCPUS must use VCPUOP_register_vcpu_info */
> >  #define XEN_LEGACY_MAX_VCPUS 1
> >  
> > -typedef uint32_t xen_ulong_t;
> > +typedef uint64_t xen_ulong_t;
> > +#define PRI_xen_ulong PRIx64
> 
> ... this doesn't seem to have an x86 counterpart.

Indeed, I haven't tried but I'm sure it must be broken on x86.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel