Re: [Xen-devel] [PATCH v4 4/6] xen: introduce XEN_GUEST_HANDLE_PARAM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-08-22 at 12:08 +0100, Stefano Stabellini wrote:
> +#define set_xen_guest_handle_raw(hnd, val)                  \
> +    do {                                                    \
> +        typeof(&(hnd)) t = &(hnd);                          \
> +        _t->q = 0;                                          \
> +        _t->p = val;                                        \

You have a mix of t and _t here...

Since this macro is used in the tools it would be useful to avoid any
potentially clashing names (e.g. so -Wshadow doesn't moan).

_sxghr_tmp?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel