Re: [Xen-devel] Xen4.2 S3 regression?

[Ben Guthro <ben@xxxxxxxxxx>]

oops. I didn't reply-all on this - re-replying.

On Tue, Sep 25, 2012 at 11:10 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 25.09.12 at 16:22, Ben Guthro <ben@xxxxxxxxxx> wrote:
> I went back to an old patch that had, since it was in this same function
> that you made reference to:
> http://markmail.org/message/qpnmiqzt5bngeejk
>
> I noticed that I was not seeing the "Breaking vcpu affinity" printk - so I
> tried to get that
>
> The change proposed in that thread seems to work around this pinning
> problem.
> However, I'm not sure that it is the "right thing" to be doing.

As said back then, the original change looks a little suspicious,
and hence reverting it is certainly to be considered.

 

Which is one of the reasons I brought it up again.

 

However, I don't see yet how this is connected to you having
a problem only with pinned vCPU-s.

Well - when the command line parameter dom0_vcpu_pin exists - 

it crashes without this change. It does not crash with it, or without 

the command line parameter.

Perhaps they are unrelated.

 

But - with S3 working again (with the change here) or originally,
did you ever check whether post-resume Dom0 vCPU-s would
still be pinned? I suspect they aren't, and hence addressing the
crash may likely be achieved by properly restoring the pinning.

No, I don't believe they are pinned after resume...so while I 

suppose it is not entirely correct, it is also better than crashing.

(it is also the observed behavior in Xen-4.0.x)

 

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel