Re: [Xen-devel] fsimage - no such file

[cyberhawk001@xxxxxxxxx]

On 6/19/2012 12:36 PM, Ian Campbell wrote:
> On Tue, 2012-06-19 at 17:10 +0100, Matt Wilson wrote:
> > On Tue, Jun 19, 2012 at 04:19:27AM -0700, Mohammad Hedayati wrote:
> > > > # Node ID 6eabee6807b48c72bcc35a28170f0729500def85
> > > > # Parent  80c0677f0f8370a4542aab81ab93380b0dab25db
> > > > imported patch debian-lib-dir.patch
> > > >
> > > > diff -r 80c0677f0f83 -r 6eabee6807b4 config/StdGNU.mk
> > > > --- a/config/StdGNU.mk  Wed Jun 13 09:27:53 2012 +0100
> > > > +++ b/config/StdGNU.mk  Wed Jun 13 09:27:53 2012 +0100
> > > > @@ -34,7 +34,7 @@ BINDIR = $(PREFIX)/bin
> > > >   INCLUDEDIR = $(PREFIX)/include
> > > >   LIBLEAFDIR = lib
> > > >   LIBLEAFDIR_x86_32 = lib
> > > > -LIBLEAFDIR_x86_64 ?= lib64
> > > > +LIBLEAFDIR_x86_64 ?= lib
> > > >   LIBDIR = $(PREFIX)/$(LIBLEAFDIR)
> > > >   LIBDIR_x86_32 = $(PREFIX)/$(LIBLEAFDIR_x86_32)
> > > >   LIBDIR_x86_64 = $(PREFIX)/$(LIBLEAFDIR_x86_64)
> > > >
> > > > Can you try a fresh build with this applied and see if that helps.
> > > I have applied this patch. I think libfsimage is somehow not being
> > > affected with this. Yet, linking /usr/lib64/fs ->  /usr/lib/fs solves
> > > the problem.
> > libfsimage is going to blindly look in /usr/lib64 on non-Itanium
> > 64-bit Linux platforms. See tools/libfsimage/common/fsimage_plugin.c:134
> Oh bloody hell, I hadn't spotted that.
>
> We should definitely be setting FSIMAGE_FSDIR to something sane based on
> LIBDIR and not letting all sorts of weird heuristics kick in.
>
> Ian.
>
> > #if defined(FSIMAGE_FSDIR)
> >          if (fsdir == NULL)
> >                  fsdir = FSIMAGE_FSDIR;
> > #elif defined(__sun__)
> >          if (fsdir == NULL)
> >                  fsdir = "/usr/lib/fs";
> >
> >          if (sizeof(void *) == 8)
> >                  isadir = "64/";
> > #elif defined(__ia64__)
> >          if (fsdir == NULL)
> >                  fsdir = "/usr/lib/fs";
> > #else
> >          if (fsdir == NULL) {
> >                  if (sizeof(void *) == 8)
> >                          fsdir = "/usr/lib64/fs";
> >                  else
> >                          fsdir = "/usr/lib/fs";
> >          }
> > #endif
> >
> > Matt
SOOO, just wondering, in the above patch, should these:

-LIBLEAFDIR_x86_64 ?= lib64
+LIBLEAFDIR_x86_64 ?= lib


be also changed if installing the latest Xen 4.2-unstable on like Debian 
Wheezy? OR is this something that is not important that important?


Just curious since even in the latest Xen 4.2-unstable rev-25494, it 
still has the
LIBLEAFDIR_x86_32 = lib
LIBLEAFDIR_x86_64 ?= lib64


in the StdGNU.mk file.

Thanks


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel