Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile error of libvirt

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Jim Fehlig writes ("Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile 
error of libvirt"):
> The libvirt libxl driver doesn't use libxc directly. AFAICT, the problem
> is that libxl.h includes <xen/sysctl.h>, which has this
> 
> #if !defined(__XEN__) && !defined(__XEN_TOOLS__)
> #error "sysctl operations are intended for use by node control tools only"
> #endif
> 
> Without the defines, Bamvor is hitting the #error directive.

I see.  Hmm.  I have investigated further and:

xl.c contained #include <xenctrl.h> which is definitely very wrong.
when I
 (a) #undef __XEN_TOOLS__ at the top of xl.c
 (b) remove that
I can reproduce the error in-tree.

I'm unsure as to whether we should expect libxl callers include
<xen/sysctl.h>.  I think my view is that including these Xen public
headers for things like Xen sysctl numbers, scheduler parameter
numbers, etc., is fine.  Ian, what do you think ?

But we definitely need to do something to stop libxl callers,
including xl, including xenctrl.h.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel