Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile error of libvirt

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-02-23 at 08:52 +0000, Ian Campbell wrote:
> On Thu, 2012-02-23 at 08:45 +0000, Ian Campbell wrote:
> > On Wed, 2012-02-22 at 21:40 +0000, Jim Fehlig wrote:
> > > Ian Jackson wrote:
> > > > Bamvor Jian Zhang writes ("Re: [Xen-devel] [xen-devel] [PATCH] libxl: 
> > > > fix compile error of libvirt"):
> > > >
> > > >> Ian Jackson wrote:
> > > >>
> > > >>> Users of libxl should not be using libxc directly and therefore should
> > > >>> not be including xenctrl.h.
> > > >>>
> > > > ...
> > > >
> > > >> but after your commit "23174:751c6dcec0d4"(remove xenctrl.h from 
> > > >> libxl.h), the aplication(like libvirt) compile fail. How do i deal 
> > > >> with it?
> > > >> it seems that add __XEN_TOOLS_ to libvirt code is not good.
> > > >>
> > > >
> > > > Can you tell us the error message you get ?  I think the problem is
> > > > probably that libvirt is trying to use libxc directly.
> > > >
> > >
> > > The libvirt libxl driver doesn't use libxc directly. AFAICT, the problem
> > > is that libxl.h includes <xen/sysctl.h>, which has this
> > >
> > > #if !defined(__XEN__) && !defined(__XEN_TOOLS__)
> > > #error "sysctl operations are intended for use by node control tools only"
> > > #endif
> > >
> > > Without the defines, Bamvor is hitting the #error directive.
> > 
> > I thought we'd discussed and resolved this ages ago but I guess we only
> > discussed it...
> > 
> > How about the following:
> 
> I also have the following,

One or both of which break the bindings build...

I'll resend as precursor to my resend of the "better defaults handling".
Simply because there are some textual conflicts between the two.

I'd still be happy to have Acks for the libxl side though (the bindings
changes will be obvious I expect)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel