[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix compile error of libvirt

Ian Jackson wrote:
> Bamvor Jian Zhang writes ("Re: [Xen-devel] [xen-devel] [PATCH] libxl: fix 
> compile error of libvirt"):
>> Ian Jackson wrote: 
>>> Users of libxl should not be using libxc directly and therefore should 
>>> not be including xenctrl.h. 
> ...
>> but after your commit "23174:751c6dcec0d4"(remove xenctrl.h from libxl.h), 
>> the aplication(like libvirt) compile fail. How do i deal with it? 
>> it seems that add __XEN_TOOLS_ to libvirt code is not good. 
> Can you tell us the error message you get ?  I think the problem is
> probably that libvirt is trying to use libxc directly.

The libvirt libxl driver doesn't use libxc directly. AFAICT, the problem
is that libxl.h includes <xen/sysctl.h>, which has this

#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
#error "sysctl operations are intended for use by node control tools only"

Without the defines, Bamvor is hitting the #error directive.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.