Re: [Xen-devel] [PATCH] tools: misc: xen-tmem-list-parse: fix output ugliness

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dan Magenheimer writes ("Re: [Xen-devel] [PATCH] tools: misc: 
xen-tmem-list-parse: fix output ugliness"):
> Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]
> > I think functions with prototypes like
> >      f(int len, char *buf)
> > should take buf[len], not buf[len+1].
> 
> FWIW, I agree completely.  I didn't write this code from
> scratch, I heavily leveraged it from elsewhere (don't
> recall exactly where, maybe xentop?).
>
> If necessary, I will rewrite the callers and API but
> I was just trying to fix an annoying bug expeditiously.
> Let me know if you won't accept it as the one-line
> ugly fix.

I really don't want to make this worse.  Previously the function would
not write past len.  So sorry, would you mind fixing the callers ?

Also if you "leveraged" this code perhaps it should be combined or the
original one fixed or something ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel