Re: [Xen-devel] [PATCH] tools: misc: xen-tmem-list-parse: fix output ugliness

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dan Magenheimer writes ("[Xen-devel] [PATCH] tools: misc: xen-tmem-list-parse: 
fix output ugliness"):
> (This should apply cleanly to 4.0, 4.1, and unstable.  It would
> be nice to apply to the next dot release of 4.0 and 4.1, but
> please definitely apply at least to unstable.)
> 
> Fix ugly parse output for xen-tmem-list-parse
> 
> This program parses the output of xm/xl tmem-list into
> human-readable format.  A missing NULL terminator sometimes
> causes garbage to be spewed where the two-letter pool type
> should be printed.
> 
> Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
> 
> diff -r 54a5e994a241 tools/misc/xen-tmem-list-parse.c
> --- a/tools/misc/xen-tmem-list-parse.c        Wed Nov 02 17:09:09 2011 +0000
> +++ b/tools/misc/xen-tmem-list-parse.c        Wed Nov 09 14:28:40 2011 -0700
> @@ -64,6 +64,7 @@
>          return;
>      for ( i = 0; i < len; i++ )
>          *buf++ = *s1++;
> +    *buf = '\0';
>  }

This has a buffer overrun AFAICT.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel