Re: [Xen-devel] [PATCH] libxl: Include a version of bsd's queue.h

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On 10/25/11 19:58, Ian Jackson wrote:
> Ian Jackson writes ("[Xen-devel] [PATCH] libxl: Include a version of bsd's 
> queue.h"):
> > We would like some linked list macros which are (a) well known to be
> > sane and (b) typesafe.  BSD's queue.h meets these criteria.
> >
> > The files in this changeset were obtained with:
> >    svn co -r 221843 svn://svn.freebsd.org/base/head/sys/sys/
> >    svn co -r 221843 svn://svn.freebsd.org/base/head/share/man/man3
> I posted this because I noticed (too late) that libxl_qmp.c includes
> <sys/queue.h>  and uses some macros that are only available in some
> queue.h versions.  This is not ideal for portability of course.
>
> I think it would be good to include this massaged queue.h and use it
> in libxl_qmp.c.
These headers cause build errors on *BSD due to collisions with the
native headers. Two solutions:

- Only use them on platforms where they do not exist
- Add a namespace prefix to the macros and use them consequently

Christoph


--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel