Re: [Xen-devel] [PATCH V2 08/11] libxl_qmp, Introduce qmp_request_handle.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("[Xen-devel] [PATCH V2 08/11] libxl_qmp, Introduce 
qmp_request_handle."):
> This structure helps keep the return code of the callback, so a
> caller can read it.

This is heading in a plausible direction but:

 * You need to state which of the members of the struct are for use by
   which parts of libxl, and when any shared members are written etc.

 * "handle" is the wrong word for this.  "handle" would refer to a
   pointer or perhaps descriptor.  This is a context/info structure.

 * The "free_it" parameter to qmp_send seems odd.  Surely it should
   just be the case that the same person that allocated the context
   should free it ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel