Re: [Xen-devel] [PATCH V2 10/11] libxl_qmp, Introduce libxl__qmp_pci_add.

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Mon, Oct 24, 2011 at 11:01, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>
>> + Â Ârc = qmp_synchronous_send(qmp, "device_add", &args, NULL, qmp->timeout);
>> + Â Âif (rc == 0) {
>> + Â Â Â Ârc = qmp_synchronous_send(qmp, "query-pci", NULL,
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â&request, qmp->timeout);
>> + Â Â Â Âif (rc == 0) {
>> + Â Â Â Â Â Ârc = request.rc;
>> + Â Â Â Â}
>
> Is every caller going to want this behaviour? Perhaps it belongs in
> qmp_sync..._send?

Yes, I think we want to know if the command and the callback have been
a success or not. And, in case we want to know if it's a protocol
error or an error in the callback, then we will just need different
value return.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel