Re: [Xen-devel] [PATCH 1/7] libxl, Introduce dm-version xenstore key.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 1/7] libxl, Introduce dm-version 
xenstore key."):
> On Fri, 2011-10-07 at 13:10 +0100, Anthony PERARD wrote:
> > The key is /local/domain/$domid/dm-version.
> 
> I've been wondering if we should introduce /libxl/$domid/ as a place for
> keeping tooltack internal droppings like this. The danger with putting
> stuff in /local/domain is that domains come to rely on them.

Also, can't the domain write to /local/domain/$domid ?  Which we don't
want, in this case.

> > +    localents[i++] = libxl__strdup(gc, 
> > libxl_device_model_version_to_string(dm_info->device_model_version));
> > +
> 
> You don't seem to use this anywhere?

Also, like several other lines here, it needs to be wrapped
(preferably, to 75 columns or so).

> This would be a bug, since it would imply an inconsistent version of
> libxl was used to create the domain? (not sure what our policy around
> this actually is / should be).

No, because the same toolstack can create domains with either version
of qemu.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel