[Xen-devel] [PATCH/RFC] don't include <xen/sysctl.h> in libxl.h

[Guido Günther <agx@xxxxxxxxxxx>]

Hi,
I'm unsure if libvirt qualifies as "node control tool":

In file included from /tmp/usr/include/libxl.h:137:0,
                 from libxl/libxl_conf.c:28:
/tmp/usr/include/xen/sysctl.h:31:2: error: #error "sysctl operations are 
intended for use by node control tools only"
In file included from /tmp/usr/include/xen/sysctl.h:35:0,
                 from /tmp/usr/include/libxl.h:137,
                 from libxl/libxl_conf.c:28:

If not it makes sense to remove the include from libxl.h and include it
in xl_cmdimpl.c directly. This allows libvirt to include libxl.h again
without defining __XEN_TOOLS__.

Does this look correct?
Cheers,
 -- Guido

Attachment: Don't include sysctl.h in public header
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel