Re: [Xen-devel] [PATCH] xl: Check for dependencies in xl

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Kamala Narasimhan writes ("Re: [Xen-devel] [PATCH] xl: Check for dependencies 
in xl"):
> My preference would to use static const over preprocessor definitions
> but I also don't mind conformance if that is why you are suggesting
> this change.

Thanks, I would have applied this patch, but:

> +
> +    if ( stat(XENSTORE_PID_FILE, &stat_buf) != 0 ) {
> +        LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
> +            "Is xenstore daemon running?\nStat on file %s returned -
> \"%s\".\n",
> +            XENSTORE_PID_FILE, strerror(errno));
> +        return ERROR_FAIL;
> +    }

This part has been word-wrapped.  You need to send patches in a way
which does not word-wrap them.

And ideally you should probably use C99 string concatenation to split
the string so as to avoid the long line.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel