Re: [Xen-API] xen-bugtool: Close file descriptors after use.

[Mike McClurg <mike.mcclurg@xxxxxxxxxx>]

Hi Gurucharan,

Dave had already forwarded this patch to the xen-bugtool owner. From him:

"The first hunk does fix a leak if we terminate
processes. I couldn't reproduce a leak the second hunk claims to fix.

"I've committed just the first hunk to trunk"

Thanks for raising that issue.

Mike

On 17/05/12 15:16, Mike McClurg wrote:
> Thanks, Gurucharan. I've sent this patch on to the xen-bugtool owner.
>
> Mike
>
> On 14/05/12 22:47, Gurucharan Shetty wrote:
> > This was a bug observed in openvswitch's ovs-bugtool.
> > The same applies to xen-bugtool. I am not sure which git
> > repo has the source code of xen-bugtool to send a proper
> > patch. This attached patch (text file)is on the xen-bugtool
> > of xenserver6.0.
> >
> > --8<--------------------------cut here-------------------------->8--
> > In xen-bugtool, we do a bunch of Popen calls to
> > get the results of some shell commands with stdout
> > set to PIPE. Once we are done, we need to
> > close the file descriptors. If not, there is a chance of
> > running out of file descriptors.
> >
> > Signed-off-by: Gurucharan Shetty<gshetty@xxxxxxxxxx>
>
> _______________________________________________
> Xen-api mailing list
> Xen-api@xxxxxxxxxxxxx
> http://lists.xen.org/cgi-bin/mailman/listinfo/xen-api

_______________________________________________
Xen-api mailing list
Xen-api@xxxxxxxxxxxxx
http://lists.xen.org/cgi-bin/mailman/listinfo/xen-api