[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-API] xen-bugtool: Close file descriptors after use.

  • To: xen-api@xxxxxxxxxxxxx
  • From: Gurucharan Shetty <gshetty@xxxxxxxxxx>
  • Date: Mon, 14 May 2012 14:47:19 -0700
  • Delivery-date: Mon, 14 May 2012 21:47:35 +0000
  • List-id: User and development list for XCP and XAPI <xen-api.lists.xen.org>

This was a bug observed in openvswitch's ovs-bugtool.
The same applies to xen-bugtool. I am not sure which git
repo has the source code of xen-bugtool to send a proper
patch. This attached patch (text file)is on the xen-bugtool
of xenserver6.0.

--8<--------------------------cut here-------------------------->8--
In xen-bugtool, we do a bunch of Popen calls to
get the results of some shell commands with stdout
set to PIPE. Once we are done, we need to
close the file descriptors. If not, there is a chance of
running out of file descriptors.

Signed-off-by: Gurucharan Shetty <gshetty@xxxxxxxxxx>

Attachment: patch-xen-bugtool
Description: Binary data

Xen-api mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.