[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-API] [PATCH] imported patch removing-warnings

(I apologies if my email is badly formatted... silly web mail client in use)

My quick comments are:
1. a lot of warnings will be attributed to the "xen hg user" (have a look at 
"hg export 0")
2. as a special case, it might be good to view fixing warnings as a task for 
newbies to help familiarise them with the codebase. I would agree with the 
notion that henceforth, new warnings should be treated as bugs and the creator 
should tidy them up.


From: Jonathan Knowles
Sent: 10 November 2010 12:20
To: Rok Strnisa
Cc: Vincent Hanquez; xen-api@xxxxxxxxxxxxxxxxxxx; Dave Scott
Subject: Re: [Xen-API] [PATCH] imported patch removing-warnings

On 10/11/10 12:08, Rok Strnisa wrote:
> Because this will take some effort, I've decided to not do it all
> myself, but rather use the source control to identify who is
> responsible for each warning, and delegate it to them --- originally
> an idea by Jonathan Knowles.

Yes -- it ought to be possible to distribute this work:

1. grep the results of a successful build for warnings
2. convert the warnings into a warning list w, where w = [(file, line)]
3. use hg annot to identify the person that last touched each line
4. partition list w into a per-user list of warnings: [(user, [(file,
5. create a bug report for each user, along with their list of warnings.



xen-api mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.