RE: [Xen-API] [PATCH] imported patch removing-warnings

[Rok Strnisa <rok.strnisa@xxxxxxxxxx>]

> > My patch did not introduce any future hard-to-find bugs, since any
> > change of the type you describe above would still have been silently
> > ignored by the compiler even without the change.
> 
> yes, the partial application would not have triggered either when it's
> linked to a name, however you do remove potential audit site (warning
> lines), since "unused variable" warnings has been silenced.

As I mentioned in my previous email, a commented-out variable name may well be 
more visible and targeted than a warning hidden in a sea of them.

If you would like to discuss this further, I suggest taking it offline.

Regards,
Rok

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api