Re: [win-pv-devel] [PATCH] Fix VS2012 builds

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Paul Durrant [mailto:pdurrant@xxxxxxxxx]
> Sent: 26 July 2016 09:26
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Paul Durrant
> Subject: [PATCH] Fix VS2012 builds
> 
> Building for OS earlier than Windows 7 now requires use of procgrp.lib
> since KeGetCurrentProcessorEx() is used. Since the base OS of VS2012 builds
> is Vista, these have been failing since commit 8cb5c156.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

I found a bug in testing this because the compatibility library was not being 
initialized. I'll send v2.

  Paul

> ---
>  src/xennet/receiver.c        | 1 +
>  vs2012/xennet/xennet.vcxproj | 4 ++--
>  vs2013/xennet/xennet.vcxproj | 4 ++--
>  3 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/src/xennet/receiver.c b/src/xennet/receiver.c
> index 964ca90..ba05799 100644
> --- a/src/xennet/receiver.c
> +++ b/src/xennet/receiver.c
> @@ -30,6 +30,7 @@
>   */
> 
>  #include <ndis.h>
> +#include <procgrp.h>
>  #include <tcpip.h>
>  #include <xen.h>
> 
> diff --git a/vs2012/xennet/xennet.vcxproj b/vs2012/xennet/xennet.vcxproj
> index f0e9073..f383e85 100644
> --- a/vs2012/xennet/xennet.vcxproj
> +++ b/vs2012/xennet/xennet.vcxproj
> @@ -32,7 +32,7 @@
> 
>      <ItemDefinitionGroup>
>               <ClCompile>
> -
>       <PreprocessorDefinitions>__MODULE__="XENNET";NDIS_MINIPOR
> T_DRIVER;NDIS_WDM=1;NDIS61_MINIPORT=1;POOL_NX_OPTIN=1;%(Prepr
> ocessorDefinitions)</PreprocessorDefinitions>
> +
>       <PreprocessorDefinitions>__MODULE__="XENNET";NDIS_MINIPOR
> T_DRIVER;NDIS_WDM=1;NDIS61_MINIPORT=1;POOL_NX_OPTIN=1;NT_PRO
> CESSOR_GROUPS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
>                       <WarningLevel>EnableAllWarnings</WarningLevel>
> 
>       <DisableSpecificWarnings>4711;4548;4820;4668;4255;6001;6054;28196
> ;%(DisableSpecificWarnings)</DisableSpecificWarnings>
> 
>       <MultiProcessorCompilation>true</MultiProcessorCompilation>
> @@ -40,7 +40,7 @@
>               </ClCompile>
>               <Link>
> 
>       <ImageHasSafeExceptionHandlers>false</ImageHasSafeExceptionH
> andlers>
> -
>       <AdditionalDependencies>$(DDK_LIB_PATH)\ndis.lib;$(DDK_LIB_PA
> TH)/libcntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;%(AdditionalDependencies)</
> AdditionalDependencies>
> +
>       <AdditionalDependencies>$(DDK_LIB_PATH)\ndis.lib;$(DDK_LIB_PA
> TH)/libcntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;$(DDK_LIB_PATH)/procgrp.lib;
> %(AdditionalDependencies)</AdditionalDependencies>
> 
>       <EnableCOMDATFolding>false</EnableCOMDATFolding>
>               </Link>
>               <Inf>
> diff --git a/vs2013/xennet/xennet.vcxproj b/vs2013/xennet/xennet.vcxproj
> index cbe57f5..48ecabe 100644
> --- a/vs2013/xennet/xennet.vcxproj
> +++ b/vs2013/xennet/xennet.vcxproj
> @@ -27,7 +27,7 @@
>    </PropertyGroup>
>    <ItemDefinitionGroup>
>      <ClCompile>
> -
> <PreprocessorDefinitions>__MODULE__="XENNET";NDIS_MINIPORT_DRIVE
> R;NDIS_WDM=1;NDIS61_MINIPORT=1;POOL_NX_OPTIN=1;%(Preprocessor
> Definitions)</PreprocessorDefinitions>
> +
> <PreprocessorDefinitions>__MODULE__="XENNET";NDIS_MINIPORT_DRIVE
> R;NDIS_WDM=1;NDIS61_MINIPORT=1;POOL_NX_OPTIN=1;NT_PROCESSOR
> _GROUPS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
> 
> <AdditionalIncludeDirectories>$(WindowsSdkDir)\include\km;..\..\include;..
> \..\include\xen;</AdditionalIncludeDirectories>
>        <WarningLevel>EnableAllWarnings</WarningLevel>
> 
> <DisableSpecificWarnings>4711;4548;4820;4668;4255;6001;6054;28196;%(Disa
> bleSpecificWarnings)</DisableSpecificWarnings>
> @@ -39,7 +39,7 @@
>      </ResourceCompile>
>      <Link>
> 
> <ImageHasSafeExceptionHandlers>false</ImageHasSafeExceptionHandlers>
> -
> <AdditionalDependencies>$(DDK_LIB_PATH)\ndis.lib;$(DDK_LIB_PATH)/libc
> ntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;%(AdditionalDependencies)</Additio
> nalDependencies>
> +
> <AdditionalDependencies>$(DDK_LIB_PATH)\ndis.lib;$(DDK_LIB_PATH)/libc
> ntpr.lib;$(DDK_LIB_PATH)/aux_klib.lib;$(DDK_LIB_PATH)/procgrp.lib;%(Addi
> tionalDependencies)</AdditionalDependencies>
>        <EnableCOMDATFolding>false</EnableCOMDATFolding>
>      </Link>
>      <Inf>
> --
> 2.1.1


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel