Re: [Xen-ia64-devel] [PATCH] fix oops message from timer_interrupt on VTI domain

[Aron Griffis <aron@xxxxxx>]

Atsushi SAKAI wrote:  [Mon Jan 22 2007, 07:36:55PM EST]
> Oops: timer tick before it's due (itc=ed98bb5849,itm=ed98bb5849)
> Oops: timer tick before it's due (itc=f20bca8ca3,itm=f20bca8ca3)
> Oops: timer tick before it's due (itc=f4ea4e2b32,itm=f4ea4e2b32)
...
> 
> These oops messages are generated
> because timer_interrupt checks the condition itc > itm.

Is that the right comparison though?  itc isn't guaranteed to return
different values on subsequent fetches, and the interrupt is generated
when itc == itm, right?  So shouldn't the condition be itc >= itm?

Aron

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel