Re: [Xen-ia64-devel] [PATCH] fix oops message from timer_interrupt on VTI domain

[Alex Williamson <alex.williamson@xxxxxx>]

On Tue, 2007-01-23 at 09:36 +0900, Atsushi SAKAI wrote:
> diff -r 91be8436952d xen/arch/ia64/vmx/vlsapic.c
> --- a/xen/arch/ia64/vmx/vlsapic.c       Wed Jan 10 10:37:41 2007 -0700
> +++ b/xen/arch/ia64/vmx/vlsapic.c       Tue Jan 23 09:21:13 2007 +0900
> @@ -59,7 +59,7 @@ extern void vmx_reflect_interruption(u64
>                                       u64 vector, REGS *regs);
>  static void update_last_itc(vtime_t *vtm, uint64_t cur_itc)
>  {
> -    vtm->last_itc = cur_itc;
> +    vtm->last_itc = cur_itc + 1;
>  }
>  
>  /* 

   In theory, I think this is probably fine.  But wouldn't it make more
sense to have the caller do the increment?  Something like:

        update_last_itc(vtm, VCPU(vcpu, itm) + 1);

Preferably with a nice comment describing the condition that + 1 is
trying to avoid.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel