Re: [Xen-ia64-devel] [PATCH 2/2] FPSWA emulation support

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi Tristan,

>Le Jeudi 18 Mai 2006 12:36, Masaki Kanno a 馗rit :
>> [2/2]
>
>diff -r d2f6e3d70f22 xen/arch/ia64/xen/hypercall.c
>--- a/xen/arch/ia64/xen/hypercall.c    Wed May 17 16:31:46 2006 -0600
>+++ b/xen/arch/ia64/xen/hypercall.c    Thu May 18 12:43:02 2006 +0900
>[...]
>+static fpswa_ret_t
>+fw_hypercall_fpswa (struct vcpu *v)
>+{
>+      return ((fpswa_ret_t) {PSCBX(v, fpswa_ret.status),
>+                               PSCBX(v, fpswa_ret.err0),
>+                               PSCBX(v, fpswa_ret.err1),
>+                               PSCBX(v, fpswa_ret.err2)});
>+}
>Why not return PSCBX(v, fpswa_ret) ?
>Avoid this function.
>

Ok, I will correct it.

>@@ -61,6 +62,7 @@ struct arch_domain {
>     char *cmdline;
>     int efi_virt_mode;                /* phys : 0 , virt : 1 */
>     void *efi_runtime;
>+    void *fpswa_inf;
> };
>Comments for efi_runtime and fpswa_inf are welcome!
>

Ok, I will add comment.

Best regards,
 Kan

>Thank you for this work,
>Tristan.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel