Re: [Xen-ia64-devel] [PATCH 1/2] FPSWA emulation support

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi Tristan,

>Le Jeudi 18 Mai 2006 12:36, Masaki Kanno a 馗rit :
>Very minor comments:
>
>[...]
>+static void
>+xen_increment_iip(struct pt_regs *regs)
>+{
>+      struct ia64_psr *ipsr = (struct ia64_psr *)&regs->cr_ipsr;
>+      if (ipsr->ri == 2) { ipsr->ri=0; regs->cr_iip += 16; }
>+      else ipsr->ri++;
>+      return;
>+}
>There is already a vcpu_increment_iip.  Maybe you should merge both: 
>vcpu_increment_iip may call regs_increment_iip.
>(rename btw).

Ok, I will merge these function.

>
>[...]
>+static unsigned long
>+handle_fpu_swa_for_domain (int fp_fault, struct pt_regs *regs, unsigned 
>long isr)
>+{
>+      struct vcpu *v = current;
>+      IA64_BUNDLE bundle;
>+      IA64_BUNDLE __get_domain_bundle(UINT64);
>+      unsigned long fault_ip;
>+      fpswa_ret_t ret;
>+
>+      fault_ip = regs->cr_iip;
>+      if (!fp_fault && (ia64_psr(regs)->ri == 0))
>+              fault_ip -= 16;
>A comment is required here.

Ok, I will add comment.

>
>[...]
>+      if (ret.status) {
>+              PSCBX(v, fpswa_ret.status) = ret.status;
>+              PSCBX(v, fpswa_ret.err0)   = ret.err0;
>+              PSCBX(v, fpswa_ret.err1)   = ret.err1;
>+              PSCBX(v, fpswa_ret.err2)   = ret.err2;
>A single assignment should be ok: PSCBX(v, fpswa_ret) = ret;

Ok, I will correct it.

>
>Tristan.
>

Best regards,
 Kan



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel