[Xen-ia64-devel] Re: PATCH for warnings; was "-Wall" option doesn't work

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Vendredi 13 Janvier 2006 00:41, Magenheimer, Dan (HP Labs Fort Collins) a 
écrit :
> I tested this patch and was about to commit it but noticed
> that there was no "Signed-off-by" line.  In support of
> Kevin's message the other day and Xen patch standards,
> could I ask you to please resend the patch with a valid
> "Signed-off-by" line?  If there are no other changes in
> the patch file, I will commit it without further testing.
Hi,

I think I miss something.  There is a Signed-off-by line in the patch:
  # HG changeset patch
  # User tristan.gingold@xxxxxxxx
  # Node ID 34a8366f42ac3347face862e5f59a3f3aeff8589
  # Parent  1507c5499a92a7701db9cc3b0bf9ac5fb3fa8ee2
  Enable warnings and fix a few one (those which occur in almost every file).
  The next step is to fix warnings one by one.

  Signed-off-by: Tristan Gingold <tristan.gingold@xxxxxxxx>

  diff -r 1507c5499a92 -r 34a8366f42ac xen/arch/ia64/Rules.mk
  --- a/xen/arch/ia64/Rules.mk  Fri Jan  6 18:39:28 2006
  +++ b/xen/arch/ia64/Rules.mk  Thu Jan 12 07:58:30 2006
  @@ -23,10 +23,10 @@
Maybe this is the wrong place ?  In the Kevin's message, the place of the
Signed-off-by line is not very explicit and I thought it should be placed in 
the patch commit message.

Tristan.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel