[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-ia64-devel] RE: PATCH for warnings; was "-Wall" option doesn't work
I tested this patch and was about to commit it but noticed that there was no "Signed-off-by" line. In support of Kevin's message the other day and Xen patch standards, could I ask you to please resend the patch with a valid "Signed-off-by" line? If there are no other changes in the patch file, I will commit it without further testing. Thanks, Dan > -----Original Message----- > From: Tristan Gingold [mailto:Tristan.Gingold@xxxxxxxx] > Sent: Thursday, January 12, 2006 4:53 AM > To: Tian, Kevin; Xu, Anthony; > xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Magenheimer, Dan (HP Labs > Fort Collins) > Subject: PATCH for warnings; was "-Wall" option doesn't work > > Le Jeudi 12 Janvier 2006 09:44, Tian, Kevin a écrit : > > I think above patches to fix warning are very important > and always > > welcomed for stability. Maybe Dan was in busy with other > more important > > threads at time you sent out them. Could you re-send them out? > > > > >For sure, fixing warnings is *very* boring. Some are in fact bugs: > > > function called with less arguments, very dubious casts... > > >I really think warnings must be enabled and the earlier is > the better. > > > > > >Tristan. > > > > Absolutely agree. > Hi, > > here is the (small) patch which enable warnings and fixes > those which occurs > in every file. > This is really a minimal patch. I think this is a good start point. > > Tristan. > _______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-ia64-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |