[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xen/arm: its: unlink the guest device when mapping fails
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Mykola Kvach <Mykola_Kvach@xxxxxxxx>
- Date: Fri, 20 Nov 2026 20:52:14 +0000
- Accept-language: en-US, uk-UA
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mMPvKSzhDPgoKgOrw/x+lObknh/fOYrWvlw9dsMDZVM=; b=L6vtwwbZZtxQyPwAkzbFY5qOj1valn49r0fyBy5tgyZ6n4ql2vXmDMEuGXhD77/sIAtwsB4UUgFayXaewYTBHFL9gFSIylDbhu2M4v72loXmOc/wkgHXRo+tgR4GAJkwBb/uR/2fyCuefVxtFn67Z5zFcCm2PhvgT2embn99OHrE8ZW3pcR+dLLLLbafHNuRHXx07KrLYKSlYXuyTN9Xz78QmBmpOkCgHR3pf33z+d6Vb/HFhyTMHllUxpU0nx5f4kP2Hsv8cNcKytK/qc0mTHTjId2+BY3wrCWD1qk2ZK8P+jxdL0OYKDlITG6D5NCpL0dgT3nOTt7/myIju6BSfw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i70xlf3AltHVR5iyYy/8Ux9f8TZgZqxjGkpRcWLNI69MnWvh6MkulSJ1jKqE/128Z/0U9P3gdzBq6W/g9PQ7JfGCS3EjLx8qfHO6MQMTAmr9hUY+3zcPsXaqoKxsHSaTXS6KTOXegqzFFtsZpGEflcKDoUOIYkku4Df/uZGCImIyZkW4jM5cKYBHA0a7tMVKPZTZEm3VkKKYLtuWSt9aXkoPEyyspIpPqlzwQPiXrRHWky2akHyyMPws/tYmPKCqgtAOMm4U8vQz+XsR436pEnxdDwtLrYFbiTjsYRJ/SpjCVjjgG2AniZhWmfzgNOrWh6PJqxLcieiRKZbexOTpMQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 20 Nov 2026 20:52:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdeTEFZ0qAZvDC30y5Z8fo8wRpjg==
- Thread-topic: [PATCH] xen/arm: its: unlink the guest device when mapping fails
gicv3_its_map_guest_device() adds the device to the domain's RB tree
before it allocates the host LPIs for the device. If an allocation
fails, the error path frees the device but leaves it in the tree.
A later lookup then walks into freed memory. The stale node corrupts
the device tree, and remove_mapped_guest_device() frees the ITT pages
a second time. The double free hits BUG() in free_heap_pages() and
panics Xen.
The hardware domain (Dom0) can trigger this. The host LPI pool is
limited, so Dom0 can fill it with large MAPD commands and make the next
MAPD fail.
Erase the node under its_devices_lock before the error path releases
the device.
Fixes: 69082e1c210d ("ARM: GICv3 ITS: introduce device mapping")
Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
---
xen/arch/arm/gic-v3-its.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index d561def0e4..f2fe596490 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -915,6 +915,10 @@ int gicv3_its_map_guest_device(struct domain *d,
if ( ret )
{
+ spin_lock(&d->arch.vgic.its_devices_lock);
+ rb_erase(&dev->rbnode, &d->arch.vgic.its_devices);
+ spin_unlock(&d->arch.vgic.its_devices_lock);
+
/* Clean up all allocated host LPI blocks. */
for ( ; i >= 0; i-- )
{
--
2.53.0
|