[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xen/arm: vITS: check the target vCPU in INVALL
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Mykola Kvach <Mykola_Kvach@xxxxxxxx>
- Date: Fri, 20 Nov 2026 19:37:22 +0000
- Accept-language: en-US, uk-UA
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=baXQA/ItfRd6YuaK3WplqYtQ/XUgijoCy5fcI2XamBY=; b=iRS+xNPCLoPZ1XYbI0xDuL/L2DW0XTnPSuMKNOKABSJR7HZlz0+zhQvR9HHuL0p9Kp4A9JmyKkp7UXkCkOFkkQfgM4Cwh5khd5jC4lEdnfcP1hlZI9E8xT71holE2k0VhnjK9IbFZ/8UuXyhgAZd8LKhyA7bFx5+OzStfM24qJQyK5T/OMSnb15n5uCFOZP8vzzqwx6Pdu2UVvrNW/tmyOO9c7TCFVE7EOQKSSgFYm5/fgfz7jVq69ZW1R8uxvthCj/xUSxi/4t5o2r9qXLCj1ipG+5PklM3yDfWJYtp/E0PQWsDGMNukVKMOVPPxhxzpGtuuYrsbgZRMObTOMD8Pg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pspFkQiN+Si5jLc5HaArYuCVXs6s/Jm8QZuIxfMgLsDjfq/ENtLuD9Kfi6dAcdTwwBsirFTJ718bjjX4ryKDxG3eGhg36cIA42FNG+cBhxW4Efr7OPIOVwnC1ofyXsL6O2uKvTWZh4zu+JmQYc98VyDQ6EYoAM+VcMp5K5FNSp9DUS+IYeP40FTcip1wqzcdP+P70c/BZ7Cnshd5Z+UL2JCCGyX/rBslaJXkR8S2fJiEQkNy5zurXEo3pjBVf97qwnygms3wZyOd8wbxGuZbs5bwvc6PTCMZL9JkByrCe2RcM56Hq9QKlb2KUt9eKFAdrZ+90pOaJszQmBcm0yk3+Q==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 20 Nov 2026 19:37:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHdeSaQaWCX7o4BoUqv0DaFMGf86A==
- Thread-topic: [PATCH] xen/arm: vITS: check the target vCPU in INVALL
get_vcpu_from_collection() can return NULL if the collection entry
cannot be read or does not identify a vCPU. its_handle_invall() then
dereferences NULL when taking the vCPU's vGIC lock, crashing the
hypervisor.
Return -ENOENT to the vITS command dispatcher when the lookup fails.
Fixes: e975cca32bde ("ARM: vITS: handle INVALL command")
Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
---
xen/arch/arm/vgic-v3-its.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
index 79d056e21a..b2103d820d 100644
--- a/xen/arch/arm/vgic-v3-its.c
+++ b/xen/arch/arm/vgic-v3-its.c
@@ -533,6 +533,9 @@ static int its_handle_invall(struct virt_its *its, uint64_t
*cmdptr)
vcpu = get_vcpu_from_collection(its, collid);
spin_unlock(&its->its_lock);
+ if ( !vcpu )
+ return -ENOENT;
+
spin_lock_irqsave(&vcpu->arch.vgic.lock, flags);
read_lock(&its->d->arch.vgic.pend_lpi_tree_lock);
--
2.53.0
|