[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/riscv: add support for riscv,isa-extensions devicetree property



On 2026-11-19 20:33:51+01:00, Oleksii Kurochko wrote:
> [ ... 11 lines skipped ... ]
> This reads as if skipping were the new behaviour. Maybe something like:
> 
>    "Currently, a CPU with neither property is skipped with a message.
>     Make this an error instead, as a skipped CPU is left out of the
>     intersection and Xen could then use extensions that CPU lacks."
> 
> Also, the same argument applies to CPU nodes for which
> dt_get_cpuid_from_node() fails: they are still silently skipped. Either
> handle them the same way or explain why that case is different.
If it is handled in the same way, then it could worth to do it in a
dedicated patch in this patch series.
> [ ... 60 lines skipped ... ]
> Mixing the return code check with reading the riscv,isa property in one
> condition makes the last "else" ("-ENOENT and no riscv,isa") not obvious.
> I think a switch ( ret ), or handling -EINVAL first and then -ENOENT
I agree the switch would be better

-- 
Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.