[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 24/26] ci: add initial NS16550-compatible XTF test





On 11/11/26 8:47 PM, dmukhin@xxxxxxxx wrote:
From: Denis Mukhin <dmukhin@xxxxxxxx>

Enable simple functional test for NS16550-compatible emulator by adding
   CONFIG_VUART_NS16X50=y
   CONFIG_SHADOW_PAGING=y

It would help to say what the test checks, and why SHADOW_PAGING is
needed. If it is something obvious and there is no sense to put this infromation in commit message then could you please just for me explain why SHADOW_PAGING should be enabled?

for alpine-3.24-x86_64-gcc-debug Xen build.

Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
  automation/gitlab-ci/build.yaml       |  2 ++
  automation/gitlab-ci/test.yaml        | 10 ++++++++++
  automation/scripts/include/xtf-runner |  2 ++
  3 files changed, 14 insertions(+)

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index 3d37e0b572d0..f2072f6a9829 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -290,6 +290,8 @@ alpine-3.24-x86_64-gcc-debug:
        CONFIG_UBSAN_FATAL=y
        CONFIG_MICROCODE_SCAN_DEFAULT=y
        CONFIG_XHCI=y
+      CONFIG_VUART_NS16X50=y
+      CONFIG_SHADOW_PAGING=y
debian-13-x86_64-gcc-debug:
    extends: .gcc-x86_64-build-debug
diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 96127995d7be..4f4ce8aab9e9 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -785,6 +785,16 @@ qemu-xtf-argo-x86_64-gcc-debug:
    needs:
      - alpine-3.24-x86_64-gcc-debug
+qemu-xtf-emul-ns16x50-x86_64-gcc-debug:
+  extends: .qemu-smoke-x86_64
+  variables:
+    TEST_TIMEOUT_OVERRIDE: 60
+    BOOT_MSG: "NS16550-compatible emulator tests"
+  script:
+    - ./automation/scripts/qemu-xtf.sh x86_64 hvm64 emul-ns16x50 2>&1 | tee 
${LOGFILE}

As far as I can see, emul-ns16x50 isn't in upstream XTF. With the
default XTF_SRC_URI/XTF_SRC_BRANCH (xenbits master) this job would fail
to find the test; only 26/26, marked "do not merge", points CI at your
XTF branch. Has the XTF test been posted? IIRC, it is posted. I think this patch has to wait until it's in XTF, and the cover letter should say so.

+  needs:
+    - alpine-3.24-x86_64-gcc-debug
+
  qemu-smoke-riscv64-gcc:
    extends: .qemu-riscv64
    script:
diff --git a/automation/scripts/include/xtf-runner 
b/automation/scripts/include/xtf-runner
index d1ef888465c3..41deb49d1c5d 100644
--- a/automation/scripts/include/xtf-runner
+++ b/automation/scripts/include/xtf-runner
@@ -70,6 +70,8 @@ function xtf_build_cmdline()
      declare -a cmdline=()
      declare -A per_test_args=(
          [argo]="argo=1,mac-permissive=1"
+        # QEMU emulates COM1 (0x3f8) by default, use COM2 for test
+        [emul-ns16x50]="vuart=0:ns16550,com2 -- console=com2"

Could the comment say why COM1 isn't used? Xen's own console is on
QEMU's COM1 (console=com1 in XEN_CMDLINE), but since the test domain's
accesses to an emulated port are intercepted anyway, it's not obvious
to me that an emulated COM1 wouldn't work as well.

Also, no CI build enables CONFIG_VUART_NS16X50_DEBUG, which is how the
build failure in 13/26 went unnoticed. Adding it to one of the debug
builds would cover that code.

~ Oleksii



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.