|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v8 16/26] emul/ns16x50: add Kconfig options
On 11/11/26 8:47 PM, dmukhin@xxxxxxxx wrote: From: Denis Mukhin <dmukhin@xxxxxxxx> Add initial Kconfig options configure NS16550-capable emulator. Nit: "options to configure the NS16550-compatible emulator". As said in my reply to the cover letter, 04/26 already makes ns16x50.o depend on CONFIG_VUART_NS16X50, so nothing added by 04..15 is compiled until this patch; that's how the build failure from 13/26 went unnoticed. Introducing VUART_NS16X50 (default n) in 04/26 would avoid that. Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx> --- xen/common/emul/vuart/Kconfig | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/xen/common/emul/vuart/Kconfig b/xen/common/emul/vuart/Kconfig index ce1b976b7da7..353a6325180e 100644 --- a/xen/common/emul/vuart/Kconfig +++ b/xen/common/emul/vuart/Kconfig @@ -3,4 +3,24 @@ config VUART_FRAMEWORKmenu "UART Emulation" +config VUART_NS16X50+ bool "NS16550-compatible UART Emulator" if EXPERT + depends on X86 && HVM + select VUART_FRAMEWORK + help + In-hypervisor NS16550-compatible UART emulation. + + On x86, only one legacy PC COM port is emulated for domain with a + certain ID (set via 'vuart=<domid>:<compatible>[,com[1-4]]' command line + setting). The syntax here doesn't match the parser in 14/26, which requires the name once a compatible is given (see my reply there). + + This is strictly for testing purposes (such as early HVM guest console), + and not appropriate for use in production. + +config VUART_NS16X50_DEBUG + bool "Development: NS16550-compatible UART Emulator Debugging" Is it really useful to have "Development: " here? + depends on VUART_NS16X50 && DEBUG + help + Enable development debugging. Please describe what it does. Besides enabling the emulator's warning/info messages and the body of dump_state(), it prefixes every line of guest output with "FROM GUEST ", i.e. it changes what the guest console looks like. That's surprising for a debug option: anything matching the "(dN) " output, such as test scripts, breaks once it's enabled. Note also that ns16x50_debug() stays silent even with it (see 04/26). + endmenu ~ Oleksii
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |