[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 15/26] emul/ns16x50: enable emulator



On 11/11/26 8:47 PM, dmukhin@xxxxxxxx wrote:
From: Denis Mukhin <dmukhin@xxxxxxxx>

Commit subject: "emul/ns16x50: enable emulator"

Nit: the patch doesn't touch ns16x50.c; it wires the framework into
x86 HVM domain creation, so "x86/hvm:" (or "emul/vuart:") seems more
fitting as the prefix.


Wire emulator to domain creation code.

Introduce a helper `vuart_probe()` call to get the parsed vUART
configuration settings and use it while constructing domain with vUART.

Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
---
  xen/arch/x86/hvm/hvm.c        | 9 +++++++++
  xen/common/emul/vuart/vuart.c | 8 ++++++++
  xen/include/xen/vuart.h       | 6 ++++++
  3 files changed, 23 insertions(+)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index ef9c7cd05777..f4d2fbe75fc6 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -29,6 +29,7 @@
  #include <xen/trace.h>
  #include <xen/vm_event.h>
  #include <xen/vpci.h>
+#include <xen/vuart.h>
  #include <xen/wait.h>
  #include <xen/warning.h>
@@ -699,6 +700,10 @@ int hvm_domain_initialise(struct domain *d,
      if ( rc != 0 )
          goto fail1;
+ rc = vuart_init(d, vuart_probe(d));
+    if ( rc )
+        goto out_vioapic_deinit;
+
      stdvga_init(d);
rtc_init(d);
@@ -722,6 +727,8 @@ int hvm_domain_initialise(struct domain *d,
      return 0;
fail2:
+    vuart_deinit(d);
+ out_vioapic_deinit:

Nit: the new label doesn't follow the failN naming used around it.

~ Oleksii



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.