|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3] tpm: xen-tpmfront: fix use-after-free in backend_changed()
On Fri, Nov 20, 2026 at 04:26:16AM +0000, Suyuan Wang via B4 Relay wrote: > From: Suyuan Wang <stevewong@xxxxxxxxxxx> > > When the backend moves to Closing or Closed, backend_changed() > unregisters the device and then keeps using it: > > device_unregister(&dev->dev); > xenbus_frontend_closed(dev); > > The xenbus watch callback that calls backend_changed() does not hold a > reference to the device. The tpm_chip registered by xen-tpmfront has dev > as its parent and holds a reference to it, but tpmfront_remove() drops > that reference when it unregisters the chip. So device_unregister() can > release the last reference and free the xenbus_device, and > xenbus_frontend_closed(dev) then accesses freed memory. > > The stubdom based vTPM backend, the only one in use today, never > switches to Closing or Closed, so this path is not reached with it. It > is reached with any backend that follows the normal xenbus state > machine on shutdown. > > Take a temporary reference before unregistering and drop it after > xenbus_frontend_closed(). This keeps dev alive for the last access and > keeps the existing order, in which TPM operations are stopped before > the frontend is marked Closed. > > Found with a static analysis tool and checked by hand. > > Co-developed-by: Kaixuan Li <kaixuan.li@xxxxxxxxxx> > Signed-off-by: Kaixuan Li <kaixuan.li@xxxxxxxxxx> > Signed-off-by: Suyuan Wang <stevewong@xxxxxxxxxxx> > --- > Changes in v3: > - Drop the Fixes tag (Jarkko). No code change. > > Changes in v2: > - Say that the stubdom vTPM backend never reaches this path, and don't > ask for a stable backport (Juergen, Jarkko). No code change. There's no use-after-free to fix. Br, Jarkko
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |