[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/riscv: vsbi: add SBI TIME extension





On 11/19/26 10:34 PM, Hiago De Franco wrote:
On Thu, Nov 19, 2026 at 02:52:46PM +0100, Oleksii Kurochko wrote:


On 11/19/26 12:59 PM, Hiago De Franco wrote:

[...]



Tested by booting dom0less Linux guest, which prints "SBI TIME
extension detected". To test this, I used the fork from Oleksii [1]
(branch riscv-next-upstreaming) to boot linux guest with dom0less.

Since this is an isolated patch and applies to the xen master branch, I

Please note, though, that development happens on the staging branch; master
lags behind it, so patches should be based on staging. This one applies to
staging as is.

Noted, I was basing it on master. I will fix that.


decided to send the patch. Please let me know if this is not correct.

Generally speaking, I can't say whether this is right or wrong. IMO, we
should have a policy that we all agree on. If I'm not mistaken, Bruno
invited you to our weekly Xen RISC-V meetings, and we have one today. It
would be great if you could join us so we could discuss these things.

At this point, the patch does look independent and ready to go. However,
another option would be to take the patch to the riscv-next-upstreaming
branch, apply it there, and verify that it works. That said, this might not
be the best general approach.

The patch is currently targeting upstream/staging, which cannot boot any
guests. Strictly speaking, it is therefore difficult to verify how the patch
works without fetching [1], switching to the mentioned branch, and applying
the patch there. In this sense, the fact that staging cannot currently boot
a guest creates a kind of "logical dependency".

So, technically, we could proceed with this patch as it is. However, if you
could join today's meeting, it would be good to discuss how we should handle
similar situations with future patches and agree on a general upstreaming
policy.

Got it, since we had the call today I will prefer to proceed as the
following:

I will open a MR on https://gitlab.com/xen-project/people/olkur/xen
staging branch, we do the testing and reviews there and once we have
more work done upstream, I will resbumit or submit a v2. That way we add
code upstream that is really capable of being tested.

Just a small remark.

We don't push changes directly to staging, as it is a protected branch. Of course, force-pushing is technically possible, but that would put us out of sync with upstream Xen's staging branch, meaning we'd probably have to force-push all the time, which could lead to other issues as well. What isn't good.

Usually, changes are brought to downstream staging only after they have been merged into upstream staging. So, basically, we just need to run git pull upstream staging.

Therefore, if you want to proceed with an MR, it would be better to target riscv-next-upstream.

Feel free to suggest a better approach if you have one in mind. I'm pretty open to suggestions.

Thanks.

~ Oleksii




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.