[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 02/42] xen/riscv: address violation of MISRA C Rule 20.12 in csr_write64()



On Fri, 13 Nov 2026 16:48:23 +0100, Oleksii Kurochko 
<oleksii.kurochko@xxxxxxxxx> wrote:
> csr_write64() uses its csr parameter both as an operand of ## (to form the
> name of the CSR holding the upper half on RV32) and in ordinary,
> macro-expanded context. As the CSR_* constants are macros themselves, this
> violates MISRA C Rule 20.12.
> 
> Make csr_write64() take the CSR name without the CSR_ prefix and paste the
> prefix as well, so that the parameter is used as an operand of ## only.
> 
> [...]

Reviewed-by: Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>

-- 
Baptiste Le Duc <baptiste.le-duc@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.