[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v14 11/15] xen/arm64: Keep the early UART message in the identity mapping
- To: Mykola Kvach <mykola_kvach@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 17 Nov 2026 16:59:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hX0TrCe1JiwXtf3oAAlHYpPWuCmQQZtoVr0I+L8xCsk=; b=pzVVXbVmZdcknwqPxsx+d5nIaMnUV6N7AnDwqrJ8Y7X8vvlprYtmYNdf2qFP2kvn7zB7TZEF3sGI8teJWFnX0i5YbGZ1CV2rS9fFvpSB1d1dzvrHwmpyoH8GvkDICyip0leFe9ue8jxTAhRJqmX6qa4XVqeknlFOvXxaBwgmWQzRa1ds/wm9PEuHw04Xa2aHwKZxSGVH7l1T5C3+KpnyNl8DPRk4yQ5CBrpJQc/EEatGNd68wJgV2obFMNQRADWXDItCccv/lwP1dUq3GZfGTX1n5mTrrtT/zucXYcgpPFrgyOGu8T0l3w7xuvYNJ7VZZYjNgqp2UC18wKCRJouVbg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hX0TrCe1JiwXtf3oAAlHYpPWuCmQQZtoVr0I+L8xCsk=; b=Uxq1Cv4Lv/qIk/kcZhe07jqv4ozM+pIUrC1+IEkNFbly7rE/EFLEb0201J72k2nOwHBt7/BoiQBt6Vw26z7efLeTRDXrx8N9VO6HUC1pFqrT9VsL+0DJB9F9tO9cBanvrBeIuv7wplsJf/6W/OqGZqHkDai6eldUzxRxec/wgzF9b/Vi26GQZbZiLFj9r2AWLhcmxtWa5WknEEWXFcG3SsJy29Da0zkSYRuXjHIT37vmTCXVlXCteJKJEoe4tqHBSkss9R6PMt5l2qhtDRqFdaQx1xXnn2rb7GAdpOniJPvRBWY56w8Mb+Tqip6lRBBJdy/hAqcnsaovyf8IoEd4gg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=aR6zMzWPBw35/EvotZMgBGAGqPDalmZx/88dMTkkE+SirYtHz9+L/EeyWlC0Zw9KEkT4BUTtW8G+TI3ZdpUidCks4i92zgm/+Vbc49tEeEkCG+NCe0mCzQvIUL9pR8DHhl0NM6fj3j1j8jx6ZtgX3IA9jxyQlUYf0fKC5Zw5UupltPlf291N6rDPIUCryroWjGkZ+zJQQy28prXSW6WGEtzuGFSPsvknv+b0Sh83nYbJK3kaJXSpuG8DSb5SZR0Fcp4cCUTa9v6KSFljBxBZoDcm/RJoIaQaRhRGLHsLNUwaWhbGHub+BSh/v7kp6G5jWbeaMTkjv3KJV5Z7yFineg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PN11ezlslo/khwX4Khn1hnEN7Gy4TX9gy9V2nK5qtYWh3cpGEVypwwE672GjCm6876Jfc/SuyERiqTSWUmCjR+1OA2r+Zh575MlkpY3cQf0TSN/uSjbTqVEnaCFFCbUOhE4UmrM/73OGHo5dT7Ex1oKS0j7Ya/MyagihzUUCgHlJWInClGuSRQT+pp//o4nTel0doDxL/tUn4HpTlAJ62Dz2FDt/lN0OUq/e5OdeFz4x/lMmnEmrTOiERqx1ISt7oKucFhCJ2rmyXK/4WeJPHEsHtdUAA5QhpFNql37BvPm0UYoguHzjTRazM0iCOozJjUx6V62GYgtj1j1TKDae3A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 17 Nov 2026 17:00:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHddi+5/wTTfQS5BkKY3n/uTdMRW7cyfa0A
- Thread-topic: [PATCH v14 11/15] xen/arm64: Keep the early UART message in the identity mapping
Hi Mykola,
> On 17 Nov 2026, at 02:05, Mykola Kvach <mykola_kvach@xxxxxxxx> wrote:
>
> init_uart() uses PRINT(), which places the UART message in .rodata.str.
> This works during boot, before cache coloring relocates Xen.
>
> The upcoming SYSTEM_SUSPEND resume path will also call init_uart() with
> the MMU disabled. With cache coloring, Xen is no longer physically
> contiguous, so the PC-relative address used by PRINT() may not point to
> the string's physical location.
>
> Use PRINT_ID() to keep the message in .rodata.idmap, alongside the code
> that needs it before enabling the MMU.
>
> Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> Changes in v14:
> - New patch.
> ---
> xen/arch/arm/arm64/head.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 7d1e205353..f523427d48 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -447,7 +447,7 @@ FUNC_LOCAL(init_uart)
> #ifdef CONFIG_EARLY_UART_INIT
> early_uart_init x23, 0
> #endif
> - PRINT("- UART enabled -\r\n")
> + PRINT_ID("- UART enabled -\r\n")
> ret
> END(init_uart)
>
> --
> 2.53.0
|