[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/2] pci/rcar: Rename PCI host rcar4 to rcar
- To: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
- Date: Tue, 17 Nov 2026 18:34:06 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20260707 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 17 Nov 2026 16:34:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
16.11.2026 10:40, Mykyta Poturai пишет:
Hello Mykyta
Gen5 mostly reuses the same DesignWare integration and register layout
as Gen4, so one driver covers both. Drop the generation number from the
file and symbol names.
NIT: But rcar4_pcie_osid_*, rcar4_pcie_bdf_msk_set, struct
rcar4_pcie_priv, etc keep the generation number. Yes, the reason (the
registers exist only on Gen4) is mentioned in cover letter, but this
will not be committed to git history. I would add a sentence in the
patch description.
Signed-off-by: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
---
MAINTAINERS | 2 +-
xen/arch/arm/pci/Makefile | 2 +-
.../pci/{pci-host-rcar4.c => pci-host-rcar.c} | 32 +++++++++----------
.../pci/{pci-host-rcar4.h => pci-host-rcar.h} | 6 ++--
xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +-
5 files changed, 22 insertions(+), 22 deletions(-)
rename xen/arch/arm/pci/{pci-host-rcar4.c => pci-host-rcar.c} (88%)
rename xen/arch/arm/pci/{pci-host-rcar4.h => pci-host-rcar.h} (88%)
diff --git a/MAINTAINERS b/MAINTAINERS
index b804434d52..68b47adf81 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -504,7 +504,7 @@ T: git https://xenbits.xenproject.org/git-http/qemu-xen.git
RCAR PCI
M: Mykyta Poturai <mykyta_poturai@xxxxxxxx>
S: Supported
-F: xen/arch/arm/pci/pci-host-rcar4.c
+F: xen/arch/arm/pci/pci-host-rcar.c
Remark: pci-host-rcar.h is not covered by the RCAR PCI entry. Yes, this
is pre-existing and not caused by the rename, I thought the line was
edited anyway, so it would be a cheap addition.
I did not find any issues with current patch.
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
...
[snip]
|