[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] hw/xen: Mark legacy Xen backends as hotpluggable


  • To: qemu-devel@xxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>
  • From: "Peng Fan (OSS)" <peng.fan@xxxxxxxxxxx>
  • Date: Mon, 16 Nov 2026 10:49:57 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JMmCdE0OiytlNnCWd/SdZVB3tcPh+57VH1H5p/n+pKY=; b=iqXY7uQhT2GOA96tNYnE19fyOyYpFBOPS73k7sYCJiPL9LMWjxOYgn3xSS2J630LA0Bq5KjJKummylWPbdHGeyD6nu4DC/jHTTsdV+gYSfCkG5idXo2+YlUJFSoyF9oL2prjaVA0zbF56n7Ao1aEBHfUqnQywrYK9xkNJbZVn+Hnoz7+f3dDgyzL7TGT6fG4xhvYXmxkEqN6bTMeM7TFSLevuIOyXR2JRIWs+FLVX/4ccdqIG17H8GsEp/ulSIeQTiLK2EcE+F9kK3EaWizPQXKURtP0E2opl893j5WHI2SJtKvF02b29+9EbMXRowfZB8mvfHLcbWj4TKVv6BDwgg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QARclO+J6vobLgw2shk22tviH03IUzpYZKz5Cf3epwA1/Jsb9LMNQ3QL3Q5sTU0lOza+HACPGy7MymfwXwVJ4EMSBQUCB7GDqIKTaJ2ZBIqNZzIM1ROIjGb1OHnwMIM2GlpdqLzaS3KDxcZaSSv5GexUJ6/WEczmLpbABApNNoNbnMmkmnJ4qn8LnawovALf0zs+wAFDSzBJFxDEM69ltSB1X36SPZ8+8dRpJpgHd4VF9+o27AipSV1FLIQXX9fp2Nq0b7eaFo3iH5NSnN5qUzviqUjdQErFvinx9iAGi2T89sNpa+Zy6Juzvy336tb2HHGEjRivJ4Zoz0+73U8g8w==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1-NXP1-onmicrosoft-com header.d=NXP1.onmicrosoft.com header.i="@NXP1.onmicrosoft.com" header.h="From:Date:Subject:Message-Id:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Peng Fan <peng.fan@xxxxxxx>
  • Delivery-date: Mon, 16 Nov 2026 02:54:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

From: Peng Fan <peng.fan@xxxxxxx>

Commit 250e797ceada ("hw/xen: Have legacy Xen backend inherit from
DYNAMIC_SYS_BUS_DEVICE") changed TYPE_XENBACKEND to inherit from
TYPE_DYNAMIC_SYS_BUS_DEVICE, whose class sets hotpluggable = false.

Legacy Xen backends are created from xenstore at runtime, after the
machine is ready, so device_initfn() marks them as hotplugged. The new
class setting makes device_set_realized() reject them with:

  Device 'xen-backend' does not support hotplugging

Since xen_be_get_xendev() realizes the device with &error_fatal, QEMU
then exits. For example, "xl usbdev-attach" triggers this when the qusb
backend is created dynamically, killing the guest. The same flag also
causes qdev_unplug() to ignore these devices.

Override hotpluggable in xendev_class_init() to restore the behavior
before the offending commit.

Fixes: 250e797ceada ("hw/xen: Have legacy Xen backend inherit from 
DYNAMIC_SYS_BUS_DEVICE")
Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
---
 hw/xen/xen-legacy-backend.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/hw/xen/xen-legacy-backend.c b/hw/xen/xen-legacy-backend.c
index 7977b527127..bf4396c9460 100644
--- a/hw/xen/xen-legacy-backend.c
+++ b/hw/xen/xen-legacy-backend.c
@@ -640,6 +640,13 @@ static void xendev_class_init(ObjectClass *klass, const 
void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
 
     set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    /*
+     * Legacy Xen backends are created and destroyed dynamically from
+     * xenstore at runtime, after the machine has been initialized.
+     * TYPE_DYNAMIC_SYS_BUS_DEVICE marks devices as not hotpluggable,
+     * so override that here.
+     */
+    dc->hotpluggable = true;
     dc->bus_type = TYPE_XENSYSBUS;
 }
 

---
base-commit: e9fa1f66f0d47c74b6766e1b8b87ad7c2a9394d5
change-id: 20261116-qemu-xen-usb-1a36b002a561

Best regards,
--  
Peng Fan <peng.fan@xxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.